Changeset 351

Timestamp:

03/02/08 11:46:15 (16 years ago)

Author:

sacha

Message:

Empreinte - minor fixes

Location:

plugins/empreinte

Files:

• _define.php (modified) (1 diff)
• _install.php (modified) (1 diff)
• class.public.empreinte.php (modified) (1 diff)
• js/post.js (modified) (1 diff)

plugins/empreinte/_define.php

@@ -19 +19 @@
      /* Description*/    "Save browser information in comments",
      /* Author */        "Oleksandr Syenchuk",
-     /* Version */       '0.3',
+     /* Version */       '0.3.3',
      /* Permissions */   'contentadmin'
 );

plugins/empreinte/_install.php

@@ -29 +29 @@
 $sets->setNamespace(strtolower($label));
 
-# New install
+# New install / update (just erase settings - but not their values)
+$sets->put('empreinte_authorlink_mask','%1$s',
+     'string','AuthorLink mask',false);
+$sets->put('empreinte_allow_disable',true,
+     'boolean','Allow visitors disable Empreinte',false);
+$sets->put('empreinte_checkbox_style','margin:0pt 5px 0pt 140px;width:auto;',
+     'string','Set a style attribute to the checkbox that disables Empreinte',false);
+# We de NOT erase database contents if a previous version is installed
 if ($i_version === null) {
-     $sets->put('empreinte_authorlink_mask','%1$s',
-          'string','AuthorLink mask');
-     $sets->put('empreinte_allow_disable',true,
-          'boolean','Allow visitors disable Empreinte');
      $s->comment
           ->comment_browser('varchar',  65,true,null)
           ->comment_system('varchar',   65,true,null)
           ;
-}
-# Update
-elseif (version_compare($i_version,'0.1a','=')) {
-     $sets->put('empreinte_authorlink_mask','%1$s',
-          'string','AuthorLink mask');
-     $sets->put('empreinte_allow_disable',true,
-          'boolean','Allow visitors disable Empreinte');
-}
-elseif (version_compare($i_version,'0.1b','>=')) {
-     $sets->put('empreinte_allow_disable',true,
-          'boolean','Allow visitors disable Empreinte');
 }
 

plugins/empreinte/class.public.empreinte.php

@@ -73 +73 @@
                '<?php if ($core->blog->settings->empreinte_allow_disable): ?>'.
                '<script type="text/javascript" src="<?php echo $core->blog->url;?>?pf=empreinte/js/post.js"></script>'."\n".
-               '<script type="text/javascript">//<![CDATA['."\n".
+               '<script type="text/javascript">'."\n".
+               '//<![CDATA['."\n".
                "var post_no_empreinte_str ='<?php echo html::escapeJS(__('Do not save informations about my browser')); ?>';\n".
-               '//]]></script>'."\n".
+               "var post_empreinte_checkbox_style_str = '<?php if (\$core->blog->settings->empreinte_checkbox_style) { echo html::escapeJS(' style=\"'.\$core->blog->settings->empreinte_checkbox_style.'\"'); } ?>';\n".
+               '//]]>'."\n".
+               '</script>'."\n".
                '<?php endif; ?>';
           }

plugins/empreinte/js/post.js

@@ -25 +25 @@
      $('#comment-form fieldset:has(input[type=submit][name=preview])').
           prepend(
-               '<p style="margin:0pt 5px 0pt 140px;">' +
-               '<input type="checkbox" id="no_empreinte" name="no_empreinte" style="width:auto;" />' +
+               '<p><input type="checkbox" id="no_empreinte" name="no_empreinte"' +
+               post_empreinte_checkbox_style_str + ' />' +
                '<label for="no_empreinte">' + post_no_empreinte_str + '</label>' +
                '</p>'